linux-kernel - Re: [PATCH 0/2] tools: Add a toplevel Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120329112156.GB6409@aftab>
Date:	Thu, 29 Mar 2012 13:21:56 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Borislav Petkov <bp@...64.org>
Cc:	Michal Marek <mmarek@...e.cz>, Sam Ravnborg <sam@...nborg.org>,
	Ingo Molnar <mingo@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] tools: Add a toplevel Makefile

On Wed, Mar 28, 2012 at 07:57:01PM +0200, Borislav Petkov wrote:
> On Wed, Mar 28, 2012 at 11:51:25AM +0200, Borislav Petkov wrote:
> > I'm currently thinking I want to give the make tools/{perf,help,...}
> > approach a try because it is clear that it is a subdir of the kernel src
> > tree and it probably could support all the targets we thought about.
> > 
> > Let me play around with it a bit...
> 
> Yeah, nasty. I've almost got it to build a tool when doing
> 
> $ make tools/<toolname>
> 
> but it fails on all the targets which have implicit build rules. (It
> seems to build perf fine though because perf Makefile doesn't have
> implicit rules for %.c -> %.o etc). And I can see that implicit rules
> are being cleared in the toplevel kernel Makefile so that they don't
> kick in.
> 
> At this moment, I'm open for hints from the kbuild people, if we use the
> toplevel Makefile to build tools/, should all the tools' Makefiles have
> explicit rules or ...? Any suggestions are appreciated.

Ok, I got it:

when make is run from the toplevel kernel Makefile, MAKEFLAGS contains
'--no-print-directory -RrI /home/boris/kernel/linux-2.6' which is
passed down to the sub-make and the '-r' especially turns off the use
of built-in implicit rules, thus the problem. Clearing MAKEFLAGS in the
sub-make fixes the issue, sorry for the noise.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/