linux-kernel - On patch "Remove all #inclusions of asm/system.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120329153409.7295eda9@stein>
Date:	Thu, 29 Mar 2012 15:34:09 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	David Howells <dhowells@...hat.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: On patch "Remove all #inclusions of asm/system.h"

Hi David,

commit 9ffc93f2 "Remove all #inclusions of asm/system.h" removes a lot of
includes while its parent commit 96f951ed "Add #includes needed to permit
the removal of asm/system.h" adds only a few.  Some of the files modified
by commit 9ffc93f2 now only work due to indirect inclusion, don't they?

For example, drivers/firewire/{core-device,core-topology,ohci,sbp2}.c use
smp_rmb()¹ and used to include asm/system.h.  Now they do not include
asm/barrier.h.  Is this by mistake or on purpose?

(I only noticed the commit come in; I did not get any build error yet.
The mentioned files now get asm/barrier.h via linux/spinlock.h and
certainly via other ways as well.)

--------
¹) so does drivers/firewire/net.c but it missed to include asm/system.h
-- 
Stefan Richter
-=====-===-- --== ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/