linux-kernel - Re: [PATCH] mm/memory_failure: Let the compiler add the function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120329140525.GA10452@localhost>
Date:	Thu, 29 Mar 2012 22:05:25 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	Borislav Petkov <bp@...64.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name

On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote:
> > I agree with your change, but I'm not sure these should be pr_info() to 
> > start with, these seem more like debugging messages?  I can't see how 
> > they'd be useful in standard operation so could we just convert them to be 
> > debug instead?
> 
> Well it tells why the page recovery didn't work.
> 
> Memory recovery is a somewhat obscure path, so it's better to have
> full information.

Nod, and it won't disturb the users unless something really bad happens.

I'm fine with the patch, too.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/