linux-kernel - Re: [PATCH] ftrace: Remove a superfluous check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333041294.23924.184.camel@gandalf.stny.rr.com>
Date:	Thu, 29 Mar 2012 13:14:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	Borislav Petkov <bp@...64.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH] ftrace: Remove a superfluous check

On Thu, 2012-03-29 at 19:03 +0200, John Kacur wrote:

> >  
> >  	mutex_lock(&ftrace_lock);
> >  
> > -	if (unlikely(ftrace_disabled))
> > -		goto out_unlock;
> > -
> >  	ret = __register_ftrace_function(ops);
> >  	if (!ret)
> >  		ret = ftrace_startup(ops, 0);
> >  
> > -
> >   out_unlock:
> >  	mutex_unlock(&ftrace_lock);
> >  	return ret;
> > -- 
> 
> If you're going to do this, then you can drop the label too.
> 

Yeah, can you resubmit with John's suggestion.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/