linux-kernel - Re: [PATCH v2 1/3] IRQ: introduce irq_do_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Mar 2012 20:55:55 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiang Liu <liuj97@...il.com>
cc:	Greg KH <greg@...ah.com>, Jiang Liu <jiang.liu@...wei.com>,
	Keping Chen <chenkeping@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduce
 duplicated code

On Fri, 30 Mar 2012, Jiang Liu wrote:

> Introduce irq_do_set_affinity() to reduce duplicated code.
> This patch also fixes a minor bug in irq_move_masked_irq(),
> which treats return value IRQ_SET_MASK_OK_NOCOPY as error.

Again. Please don't do that.

A bug fix is a bug fix and a cleanup is a cleanup. Mixing both is
simply wrong. It's also completely non obvious from the subject line
that this patch contains a bug fix - minor or not is completely
irrelevant.

The order is bug fix first, then cleanup and improvements. 

Please be more careful about this.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/