linux-kernel - Re: [PATCH] percpu: use KERN_CONT in pcpu_dump_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YOWA9U3Esb2535v_iivPaXeFYYS3nWd2KKF1=MsfZ0Piw@mail.gmail.com>
Date:	Thu, 29 Mar 2012 12:51:34 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH] percpu: use KERN_CONT in pcpu_dump_alloc_info()

Hello, Joe.

On Thu, Mar 29, 2012 at 11:10 AM, Joe Perches <joe@...ches.com> wrote:
> Perhaps it's better to try to print lines
> in fewer printks?  Maybe use a line buffer?

What practical difference would that make?

> The first line could be newline terminated.
> "if (alloc)" tests for the individual newlines could be added.
> Why aren't the group widths on separate lines?
> All of the cpu_widths are on the same line as the parent group
> even if that exceeds apl.  Is that what's desired?

I frankly don't remember. I wanted something easy on the eye during
the development to verify the config results and it worked well enough
for me. If you can simplify it, please go ahead and submit a patch.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/