linux-kernel - Re: [PATCH] Let modpost parses vmlinux instead of vmlinux.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Mar 2012 22:23:45 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Alessio Igor Bogani <abogani@...nel.org>
Cc:	Frank Rowand <frank.rowand@...sony.com>,
	Rowand Frank <Frank_Rowand@...yusa.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jan Beulich <jbeulich@...ell.com>,
	Kbuild <linux-kbuild@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Tim Bird <Tim.Bird@...sony.com>,
	Anders Kaseorg <andersk@...lice.com>,
	Arnaud Lacombe <lacombar@...il.com>
Subject: Re: [PATCH] Let modpost parses vmlinux instead of vmlinux.o

On Thu, Mar 29, 2012 at 04:53:06PM +0200, Alessio Igor Bogani wrote:
> Dear Mr. Rowand,
> 
> What do you think about this patch?
> Thanks!
> 
> Ciao,
> Alessio

Hi Alession.

I am not Mr. Rowand - obviously...

The title alone looks like you are doing something wrong.
The difference between vmlinux.o and vmlinux is that the latter
is linked using the linker scripts. So a lot of sections are merged.
And modpost uses these section for the section mismatch analysis.

Then your patch fails to describe why it is needed.
And on top of this I do not understand the patch.

So a lot of things looks bad :-(

	Sam
> 
> ---
>  Makefile                 |    2 +-
>  scripts/Makefile.modpost |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 123d858..b589d1f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -876,7 +876,7 @@ quiet_cmd_vmlinux-modpost = LD      $@
>  define rule_vmlinux-modpost
>  	:
>  	+$(call cmd,vmlinux-modpost)
> -	$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $@
> +	$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $*

I do not see where the stem is coming from - and why this is needed.


>  	$(Q)echo 'cmd_$@ := $(cmd_vmlinux-modpost)' > $(dot-target).cmd
>  endef
>  
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 56dfafc..ca0db29 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -93,7 +93,7 @@ __modpost: $(modules:.ko=.o) FORCE
>  quiet_cmd_kernel-mod = MODPOST $@
>        cmd_kernel-mod = $(modpost) $@
>  
> -vmlinux.o: FORCE
> +vmlinux vmlinux.o: FORCE
>  	$(call cmd,kernel-mod)
It looks like you process both of vmlinux.o and vmlinux?!?!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/