linux-kernel - Re: [PATCH 01/14] edac: rewrite the sysfs code to use struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120329220300.GA16491@kroah.com>
Date:	Thu, 29 Mar 2012 15:03:00 -0700
From:	Greg K H <gregkh@...uxfoundation.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Linux Edac Mailing List <linux-edac@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/14] edac: rewrite the sysfs code to use struct device

On Thu, Mar 29, 2012 at 02:06:48PM -0300, Mauro Carvalho Chehab wrote:
> +static void mci_attr_release(struct device *device)
>  {
> -	int err;
> -
> -	debugf4("%s()\n", __func__);
> -
> -	while (sysfs_attrib) {
> -		debugf4("%s() sysfs_attrib = %p\n",__func__, sysfs_attrib);
> -		if (sysfs_attrib->grp) {
> -			struct mcidev_sysfs_group_kobj *grp_kobj;
> -
> -			grp_kobj = kzalloc(sizeof(*grp_kobj), GFP_KERNEL);
> -			if (!grp_kobj)
> -				return -ENOMEM;
> -
> -			grp_kobj->grp = sysfs_attrib->grp;
> -			grp_kobj->mci = mci;
> -			list_add_tail(&grp_kobj->list, &mci->grp_kobj_list);
> -
> -			debugf0("%s() grp %s, mci %p\n", __func__,
> -				sysfs_attrib->grp->name, mci);
> -
> -			err = kobject_init_and_add(&grp_kobj->kobj,
> -						&ktype_inst_grp,
> -						&mci->edac_mci_kobj,
> -						sysfs_attrib->grp->name);
> -			if (err < 0) {
> -				printk(KERN_ERR "kobject_init_and_add failed: %d\n", err);
> -				return err;
> -			}
> -			err = edac_create_mci_instance_attributes(mci,
> -					grp_kobj->grp->mcidev_attr,
> -					&grp_kobj->kobj);
> -
> -			if (err < 0)
> -				return err;
> -		} else if (sysfs_attrib->attr.name) {
> -			debugf4("%s() file %s\n", __func__,
> -				sysfs_attrib->attr.name);
> -
> -			err = sysfs_create_file(kobj, &sysfs_attrib->attr);
> -			if (err < 0) {
> -				printk(KERN_ERR "sysfs_create_file failed: %d\n", err);
> -				return err;
> -			}
> -		} else
> -			break;
> -
> -		sysfs_attrib++;
> -	}
> -
> -	return 0;
> +	debugf1("Releasing mci device %s\n", dev_name(device));
>  }

Sweet, as per the documentation in the Documentation/kobjects.txt file,
I get to publically mock you for thinking you are smarter than the
kernel and this is an acceptable way to "outwhit" the driver core from
spitting errors at you when the kobject is released.

Please fix this up, it's unacceptable.

> +static void mc_attr_release(struct device *device)
> +{
> +	debugf1("Releasing device %s\n", dev_name(device));
> +}

Hey, you did it again, not nice :(

You also just leaked memory as well :(

Please fix.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/