linux-kernel - Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Mar 2012 18:15:26 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Borislav Petkov <bp@...64.org>, Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Michal Marek <mmarek@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

On Fri, Mar 30, 2012 at 07:26:05AM +0200, Sam Ravnborg wrote:
> > $ make tools/<toolname> tinstall
> But this makes no sense.
> 
> It would be better to be consistent - so the user does not need to remember
> when to add a space and when not.
> 
> make tools/<command> where <command> is one of help, install, clean, "nothing"
> make tools/<toolname>
> make tools/<toolname>_<comand> where command is the same set of commands
> 
> 
> then a user could do:
> 
>     make tools/clean
>     make tools/perf
>     make tools/perf_install
> 
> or
> 
>     make tools/clean
>     make tools/
>     make tools/install

This one I had hard time imagining: who would install all tools but I
guess it could have it's use...

> The install target could implicitly include the build target.
> 
> With this scheme the user is up to less suprises.
> 
> All the above are only minor adjustments compared to what you already did.
> bt the consistency here is a gain (IMO).

... but yeah, those make sense to me too, let's see what the others
think, Arnaldo, Ingo?

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/