linux-kernel - Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F75E8BA.4090907@gmail.com>
Date:	Fri, 30 Mar 2012 10:09:14 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Namhyung Kim <namhyung@...il.com>, Ingo Molnar <mingo@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Jiri Olsa <jolsa@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files

On 03/30/2012 09:43 AM, Namhyung Kim wrote:
> Hi,
>
> Arnaldo Carvalho de Melo<acme@...radead.org>  wrote:
>> From: Ingo Molnar<mingo@...nel.org>
>>
>> These should not be in the Git history - they are auto-generated.
>>
>> Extend the Makefile rules of the parser files to include the generation
>> run.
>>
>> Signed-off-by: Ingo Molnar<mingo@...e.hu>
[...]
>>
>> +FLEX = $(CROSS_COMPILE)flex
>> +BISON= $(CROSS_COMPILE)bison
>
> Just out of curiousity, is this $(CROSS_COMPILE) prefix really needed
> for flex/bison?
>

I think not.  Actually, I think it is actively incorrect.

I have done quite a bit of cross building of things requiring either 
bison or flex, and have never encountered  $(CROSS_COMPILE)bison, so I 
would think that it is unlikely that many people have one.  On the other 
hand the native tools work fine.

David Daney



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/