linux-kernel - Re: [PATCH 5/6] vfs: reorganize do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120330190526.GA29050@ZenIV.linux.org.uk>
Date:	Fri, 30 Mar 2012 20:05:26 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	hch@...radead.org, mszeredi@...e.cz
Subject: Re: [PATCH 5/6] vfs: reorganize do_lookup

On Mon, Mar 26, 2012 at 12:54:23PM +0200, Miklos Szeredi wrote:
> This also eliminates the weird retry loop, that could, in theory, retry the
> cached lookup any number of times (very unlikely scenario: needs two parallel
> do_lookups and d_revalidate always returning zero).

That really needs to be carved into much smaller pieces - the sucker is
convoluted as hell and there's a lot of codepaths in there with nearly
zero test coverage.  I've split it up into provably equivalent
transformations, leading more or less to the state where yours ends up.
I _think_ I've reconstructed the sequence of changes more or less
close to what you were doing there, but the next time you have to do
something of that kind, do not collapse that into a single patch.  It's
really easier to review step by step...

Anyway, I'd put the whole thing into vfs.git#for-linus; see if you have
any problems with it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/