linux-kernel - Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFz0WyVfJgO9GDM4ssUoWPRZfY0rs+97+P6fmYtc-jnDCw@mail.gmail.com>
Date:	Fri, 30 Mar 2012 15:39:45 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
Subject: Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

On Fri, Mar 30, 2012 at 1:36 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> From: H Hartley Sweeten <hartleys@...ionengravers.com>
>
> Documentation: remove mach from dontdiff file

Grr.

Most of these patches have the same stupid problem: why the *hell* do
you repeat the single-line top-level description in both the Subject
line and the body of the email? It only results in stupid duplicate
lines in the commit logs.

This is a disease. I don't know who the heck started doing it, but
it's WRONG. It's stupid. What broken piece-of-shit tool is it that
does this braindamage?

Fix it. Stop sending these broken commit messages to people.

I'm grumpy, yes, because this is a common problem. I see it all over
the place, and it makes our commit logs look f*cking retarded.

If you absolutely need to repeat the subject line in the body of the
email, do it together with the author line, and mark it as such, ie do
this:

  From: H Hartley Sweeten <hartleys@...ionengravers.com>
  Subject: Documentation: remove mach from dontdiff file

so that git sees that it's a repeat of the subject line. Don't just
put it in the body as another stupid repeat.

                                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/