linux-kernel - Re: [PATCH] sysctl: fix restrict write access to dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+2-8GAg6x04FyZwNnBbQDhpL5Stwy+s4yZmMYRX8ZCUVjYsvQ@mail.gmail.com>
Date:	Sat, 31 Mar 2012 02:58:02 +0100
From:	Phillip Lougher <phil.lougher@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Richard Weinberger <richard@....at>,
	Phillip Lougher <plougher@...hat.com>,
	linux-kernel@...r.kernel.org,
	Dan Rosenberg <drosenberg@...curity.com>,
	"Serge E. Hallyn" <serge@...lyn.com>, Eugene Teo <eteo@...hat.com>,
	Eric Paris <eparis@...hat.com>,
	James Morris <jmorris@...ei.org>,
	Kees Cook <keescook@...omium.org>,
	Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: [PATCH] sysctl: fix restrict write access to dmesg_restrict

On Sat, Mar 31, 2012 at 1:55 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
>
> Presumably someone else fiddled with the file, patch(1) misapplied the
> hunk and I didn't notice.
>

That was my guess, the repeated near identical sysfs entries is
confusing patch.  The stable kernels also suffer from this
misapplication, but the misapplication is random, for instance I
noticed here

http://www.mail-archive.com/stable@linux.kernel.org/msg07097.html

that the patch has been misapplied to suid_dumpable.  It looks like
all of the stable kernels need to be separately checked, and if
necessary different patches need to be generated.

> Send a fix?

My original email has the fix...

Phillip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/