linux-kernel - Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120331210913.GA19965@sirena.org.uk>
Date:	Sat, 31 Mar 2012 22:09:13 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Geon Si Jeong <gshark.jeong@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

On Fri, Mar 30, 2012 at 08:56:34PM +0200, Wolfram Sang wrote:
> On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:

> > +EXPORT_SYMBOL_GPL(lm3556_write_bits);

> Seeing all these functions it may be worth converting to REGMAP.
> Then you already have regmap_update_bits and the like.

Plus cache and debug infrastructure if that's useful.

> > +static ssize_t lm3556_indicator_pattern_store(struct device *dev,
> > +					      struct device_attribute *devAttr,
> > +					      const char *buf, size_t size)

> > +static DEVICE_ATTR(pattern, 0644, NULL, lm3556_indicator_pattern_store);

> I don't know the LED subsytsem very well. Is it that specific to the chip so we
> need a DEVICE_ATTR? Or can this be generalized in the core?

Alternatively some documentation indicating what the userspace ABI is
might help someone identify if there's a relevant feature more easily :)
If it's periodic blinking then there's definitely a core feature for
that.

> > +	chip = kzalloc(sizeof(struct lm3556_chip_data), GFP_KERNEL);

devm_kzalloc()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/