linux-kernel - Re: [PATCH] scripts: refactor remove structure forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Apr 2012 20:18:51 +0800
From:	Yang Bai <hamo.by@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Jike Song <albcamus@...il.com>, mmarek@...e.cz,
	rostedt@...dmis.org, adobriyan@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: refactor remove structure forward declarations

On Sun, Apr 1, 2012 at 2:41 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> On 3/31/2012 6:59 PM, Jike Song wrote:
>> Seems broke cscope build:
>>
>> $ make cscope
>>   GEN     cscope
>> sed: can't read cscope: No such file or directory
>> make: *** [cscope] Error 2
>>
>> with V=1:
> [snip]
>> + cscope -b -f cscope.out
>> + '[' -n ']'
>> + LANG=C
>> + sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
>> \1;.*\$\/;"\tx$/d' cscope
>> sed: can't read cscope: No such file or directory
>> make: *** [cscope] Error 2
>
> Ah yes. Forgot the quotes.
>
> ---->8------
>
> Subject: [PATCH] tags.sh: Add missing quotes
>
> When $remove_structs is empty a test for empty string will turn
> into test -n with no arguments meaning true. Add quotes so an
> empty string is tested and so that make cscope works again.
>
> Reported-by: Jike Song <albcamus@...il.com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  scripts/tags.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 0d6004e..cf7b12f 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -254,6 +254,6 @@ case "$1" in
>  esac
>
>  # Remove structure forward declarations.
> -if [ -n $remove_structs ]; then
> +if [ -n "$remove_structs" ]; then
>     LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
>  fi
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>

Acked-by: Yang Bai <hamo.by@...il.com>

-- 
    """
    Keep It Simple,Stupid.
    """

Chinese Name: 白杨
Nick Name: Hamo
Homepage: http://hamobai.com/
GPG KEY ID: 0xA4691A33
Key fingerprint = 09D5 2D78 8E2B 0995 CF8E  4331 33C4 3D24 A469 1A33
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/