linux-kernel - Re: On patch "Remove all #inclusions of asm/system.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5679.1333244791@redhat.com>
Date:	Sun, 01 Apr 2012 02:46:31 +0100
From:	David Howells <dhowells@...hat.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: On patch "Remove all #inclusions of asm/system.h"

Stefan Richter <stefanr@...6.in-berlin.de> wrote:

> It's not a problem; they now get barrier.h via spinlock.h.  I just
> wondered whether absence of #include <asm/barrier.h> in those files had a
> deeper non-obvious meaning.  Since it doesn't I will just put that include
> in them next time around when I do some housekeeping there.

I suspect they should #include asm/barrier.h directly rather than relying on
spinlock.h.  There's no guarantee that on every arch spinlock.h will pull in
asm/barrier.h, I think...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/