linux-kernel - Re: [PATCH 18/21] blkcg: move blkio_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120401210955.GE6116@redhat.com>
Date:	Sun, 1 Apr 2012 17:09:56 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	axboe@...nel.dk, ctalbott@...gle.com, rni@...gle.com,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	containers@...ts.linux-foundation.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH 18/21] blkcg: move blkio_group_conf->weight to cfq

On Wed, Mar 28, 2012 at 03:51:28PM -0700, Tejun Heo wrote:
> blkio_group_conf->weight is owned by cfq and has no reason to be
> defined in blkcg core.  Replace it with cfq_group->dev_weight and let
> conf setting functions directly set it.  If dev_weight is zero, the
> cfqg doesn't have device specific weight configured.
> 
> Also, rename BLKIO_WEIGHT_* constants to CFQ_WEIGHT_* and rename
> blkio_cgroup->weight to blkio_cgroup->cfq_weight.  We eventually want
> per-policy storage in blkio_cgroup but just mark the ownership of the
> field for now.

Hi Tejun,

blkio_cgroup->weight can be thought of in a more generic manner and that
is sytem wide cgroup weight. And more than one policy should be allowed
to make use of it. That's a differnt thing that currently only CFQ makes
use of it.

For example, Fengguang posted RFC patches to try to make use of blkcg->weight
and differentiate between buffered write bandwidth.

https://lkml.org/lkml/2012/3/28/275

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/