linux-kernel - Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Apr 2012 11:22:36 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Sam Ravnborg <sam@...nborg.org>, Borislav Petkov <bp@...64.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Michal Marek <mmarek@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

On Sun, Apr 01, 2012 at 10:42:53AM +0200, Ingo Molnar wrote:
> > Make will try to update the two targets "tools/perf" and "install"
> > in parallel. And it does not look easy to teach make that when you
> > specify the target "tools/*" then the install target should just
> > be ignored and passed down to the sub-make.
> > 
> > Anything that adds more complexity to the top-level Makefile should
> > be avoided if at all possible. It is un-maintainable as-is.
> > And the consistency issue is also important.
> > 
> > I know that if I do "make install" the kernel will be installed.
> > So one could argue that the same should apply to
> > the targets below tools/.
> > But then this should be for all targets and not just install.
> > If someone come up with a clean way to do so it is fine.
> > but the original proposal with "tinstall" just do not cut it.
> 
> 'tinstall' is definitely out, no argument about that.
> 
> Viable options are:
> 
>   tools/perf install
>   tools/perf_install
>   tools/perf-install
> 
> I'm fine with either one.

What Sam said - it is not that easy and probably cannot be done
without trickery to tell make that "install" becomes a sub-target when
"tools/<toolname>" is in front of it.

OTOH, "perf_install" is easily doable and the "perf-install" one with
the "-" could be misleading since all make targets have a "_" in their
names.

I'll redo the patchset with <toolname>_install targets since this is the
most straightforward option. In that case, if one wants to build and
install perf, she simply does

$ make tools/perf_install

and the same would work for the rest of the tools in there.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/