linux-kernel - Re: [PATCH] Staging: bcm: IPv6Protocol: fixed mutiple coding style issues Fixed several coding style issues to remove most of checkpatch.pl errors and reduce the ammount of warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 2 Apr 2012 11:03:58 +0100
From:	max tottenham <mtottenh@...il.com>
To:	Kevin McKinney <klmckinney1@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: IPv6Protocol: fixed mutiple coding style
 issues Fixed several coding style issues to remove most of checkpatch.pl
 errors and reduce the ammount of warnings.

On Mon, Apr 2, 2012 at 3:54 AM, Kevin McKinney <klmckinney1@...il.com> wrote:
> Hi Max,
>
> Thanks for taking the time to submit this patch, however, there are a few minor things that need to be resolved before it can be applied by Greg.
> Second, after I applied this patch there appears to be two errors checkpatch.pl identifies.  They are:
> ERROR: need consistent spacing around '*' (ctx:WxV)
>
> #3: FILE: staging/bcm/IPv6Protocol.c:3:
>
> +static BOOLEAN MatchSrcIpv6Address(S_CLASSIFIER_RULE *pstClassifierRule,
>
>                                                      ^
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
>
> #4: FILE: staging/bcm/IPv6Protocol.c:4:
>
> +                                       IPV6Header *pstIpv6Header);
>
>                                                   ^

After looking around apparently this is to do with checkpatch.pl not
recognizing the types and thinking the the asterisk is  a
multiplication sign  instead of a
pointer(see:http://web.archiveorange.com/archive/v/1XS1vrzkSwmm4i2t22D6)
, as to fix it you would have something like

static BOOLEAN MatchSrcIpv6Address(S_CLASSIFIER_RULE * pstClassifierRule,
                                        IPV6Header * pstIpv6Header);

which conflicts with the foo *barr notation for pointers.


> Please resubmit this patch based on these comments. Thanks a lot!
>
> -Kevin

Thanks for the comments. I'll re-factor this into a small patch set shortly.


------------------------
Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/