linux-kernel - [PATCH 1/1] scripts: fix cscope breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  2 Apr 2012 13:18:37 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	mmarek@...e.cz
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, Yang Bai <hamo.by@...il.com>,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: [PATCH 1/1] scripts: fix cscope breakage

Commit 66979224c0d2 (scripts: refactor remove structure forward
declarations) introduced a breakage in tags.sh for others than tags.
So make cscope now fails with:
sed: can't read cscope: No such file or directory

Fix it by quoting remove_structs properly.

Guys, for how long has this been in -next? I update -next and run
cscope once a week and this issue is new this week. And the patch is
already in -rc1? WTF?

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Yang Bai <hamo.by@...il.com>
Cc: Stephen Boyd <sboyd@...eaurora.org>
Cc: Michal Marek <mmarek@...e.cz>
---
 scripts/tags.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index 0d6004e..cf7b12f 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -254,6 +254,6 @@ case "$1" in
 esac
 
 # Remove structure forward declarations.
-if [ -n $remove_structs ]; then
+if [ -n "$remove_structs" ]; then
     LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
 fi
-- 
1.7.9.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/