linux-kernel - Re: [PATCH 01/19 v2] avr32/mm/fault.c: Port OOM changes to do_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFPAmTSpi1nf6goe12=nM4JOCgk3XpEYB3WNaPQ582pQZdknwA@mail.gmail.com>
Date:	Mon, 2 Apr 2012 21:00:24 +0530
From:	Kautuk Consul <consul.kautuk@...il.com>
To:	Håvard Skinnemoen <hskinnemoen@...il.com>
Cc:	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	linux-kernel@...r.kernel.org,
	"Mohd. Faris" <mohdfarisq2010@...il.com>
Subject: Re: [PATCH 01/19 v2] avr32/mm/fault.c: Port OOM changes to do_page_fault

>
> Looks very good, thanks.
>
>> @@ -122,6 +124,7 @@ good_area:
>>                if (!(vma->vm_flags & VM_WRITE))
>>                        goto bad_area;
>>                writeaccess = 1;
>> +               flags |= FAULT_FLAG_WRITE;
>
> Could you remove the 'writeaccess' variable as well? It looks unused
> after applying your patch.

Sure, Ill do that and send v2.1 of this patch to you.

>
> Ug...the avr32 arch is in a terrible state. Someone appears to have
> removed the atmel_nand driver...

I don't know anything about that. :)

>
> Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/