linux-kernel - Re: [PATCH 1/1] Drivers/media/radio: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92eed2c4-aeb6-4b32-b69c-b51238ead440@email.android.com>
Date:	Mon, 02 Apr 2012 16:39:52 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Hans Verkuil <hverkuil@...all.nl>,
	Tracey Dent <tdent48227@...il.com>
CC:	linux-kernel@...r.kernel.org, shea@...alevy.com,
	torvalds@...ux-foundation.org, hans.verkuil@...co.com,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 1/1] Drivers/media/radio: Fix build error

Hans Verkuil <hverkuil@...all.nl> wrote:

>On Sunday, April 01, 2012 21:09:34 Tracey Dent wrote:
>> radio-maxiradio depends on SND_FM801_TEA575X_BOOL to build or will
>> result in an build error such as:
>> 
>> Kernel: arch/x86/boot/bzImage is ready  (#1)
>> ERROR: "snd_tea575x_init" [drivers/media/radio/radio-maxiradio.ko]
>undefined!
>> ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-maxiradio.ko]
>undefined!
>> WARNING: modpost: Found 6 section mismatch(es).
>> To see full details build your kernel with:
>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>> 
>> Select CONFIG_SND_TEA575X to fixes problem and enable
>> the driver to be built as desired.
>> 
>> v2:
>> instead of selecting CONFIG_SND_FM801_TEA575X_BOOL, select
>> CONFIG_SND_TEA575X, which in turns selects
>CONFIG_SND_FM801_TEA575X_BOOL
>> and any other dependencies for it to build.
>
>No, this is the correct patch:
>
>diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
>index 8816804..5ca0939 100644
>--- a/sound/pci/Kconfig
>+++ b/sound/pci/Kconfig
>@@ -2,8 +2,8 @@
> 
> config SND_TEA575X
> 	tristate
>-	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO ||
>RADIO_SF16FMR2
>-	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
>+	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO ||
>RADIO_SF16FMR2 || RADIO_MAXIRADIO
>+	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 || RADIO_MAXIRADIO
> 
> menuconfig SND_PCI
> 	bool "PCI sound devices"
>
>RADIO_MAXIRADIO should be treated just like RADIO_SF16FMR2, I just
>didn't
>realize at the time that it had to be added as a SND_TEA575X
>dependency.
>
>Signed-off-by: Hans Verkuil <hans.verkuil@...co.com>
Acked-by: Mauro Carvalho Chehab <mchehab@...radead.org>
>(Sorry for the late reply, I didn't have access to my cisco email for
>the last
>few days).
>
>Regards,
>
>	Hans
>
>> 
>> Reported-by: Shea Levy <shea@...alevy.com>
>> Signed-off-by: Tracey Dent <tdent48227@...il.com>
>> ---
>>  drivers/media/radio/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/media/radio/Kconfig
>b/drivers/media/radio/Kconfig
>> index 8db2d7f..b518ce5 100644
>> --- a/drivers/media/radio/Kconfig
>> +++ b/drivers/media/radio/Kconfig
>> @@ -44,6 +44,7 @@ config USB_DSBR
>>  config RADIO_MAXIRADIO
>>  	tristate "Guillemot MAXI Radio FM 2000 radio"
>>  	depends on VIDEO_V4L2 && PCI && SND
>> +	select SND_TEA575X
>>  	---help---
>>  	  Choose Y here if you have this radio card.  This card may also be
>>  	  found as Gemtek PCI FM.
>> 


Cheers,
Mauro
--
>From my phone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/