| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Apr 2012 14:49:38 -0700 From: Tejun Heo <tj@...nel.org> To: Tao Ma <tm@....ma> Cc: axboe@...nel.dk, vgoyal@...hat.com, ctalbott@...gle.com, rni@...gle.com, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, containers@...ts.linux-foundation.org Subject: Re: [PATCH 18/21] blkcg: move blkio_group_conf->weight to cfq Hello, On Tue, Apr 03, 2012 at 05:39:23AM +0800, Tao Ma wrote: > I guess blkio->weight is a generic way of abstracting the weight between > different block cgroups. It isn't and can't be. There's nothing generic about it across different policies and it's not even clear what that means. If the user chooses combine, iops limit with cfq weights, what the hell is "generic" about that weight? > Yes, currently, only cfq uses it, but I am > trying to improve Shaohua's original fiops scheduler and add cgroup > support to it. So please leave it there so that future scheduler(if > other than the fiops scheduler) can use the framework. So, if you want to implement a new blkcg policy, add the config parameters and export the stats the policy wants *yourself*. Not having clear separation between policies and generic stuff was what led us to this yucky mess and there's no way we're going back there. So, NO. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists