linux-kernel - Re: [patch] UBIFS: Add cryptographic functionality when a key is passed to the compress / decompress functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJpamw7rXn_tLcFSE07AK4nrh9QXLBNzuehzLhB+rUbMv9UePA@mail.gmail.com>
Date:	Tue, 3 Apr 2012 12:41:42 +0200
From:	Guillaume LECERF <glecerf@...il.com>
To:	Joel Reardon <joel@...mbassador.com>
Cc:	Artem Bityutskiy <dedekind1@...il.com>,
	linux-fsdevel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] UBIFS: Add cryptographic functionality when a key is
 passed to the compress / decompress functions

Hi,

2012/4/3 Joel Reardon <joel@...mbassador.com>:
>  no_compr:
>        memcpy(out_buf, in_buf, in_len);
>        *out_len = in_len;
>        *compr_type = UBIFS_COMPR_NONE;
> +       goto encrypt;

This goto seems unneeded here.

> +
> +encrypt:
> +       if (crypto_key) {
> +               u8 iv[UBIFS_CRYPTO_KEYSIZE];
> +
> +               memset(iv, 0, UBIFS_CRYPTO_KEYSIZE);
> +               ubifs_aes_crypt(out_buf, *out_len, crypto_key, iv);
> +       }




-- 
Guillaume LECERF
OpenBricks developer - www.openbricks.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/