linux-kernel - Re: [RFC 4/5] hid: Add idtags to modalias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403105731.GB14201@polaris.bitmath.org>
Date:	Tue, 3 Apr 2012 12:57:31 +0200
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Benjamin Tissoires <benjamin.tissoires@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Stephane Chatty <chatty@...c.fr>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 4/5] hid: Add idtags to modalias

> > +       /* Generic MT device */
> > +       { .driver_data = MT_CLS_DEFAULT,
> > +               HID_USB_MT_DEVICE(HID_ANY_ID,
> > +                       HID_ANY_ID) },
> 
> This breaks the mechanism used to detect serial protocol.
> A better solution would be to keep .driver_data = 0 -> this would tell
> us that the device is unknown and that we can override the given
> settings.

Good point, will do.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/