linux-kernel - Re: [PATCH 02/69] TTY: crisv10, initialize tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403114705.GR21889@axis.com>
Date:	Tue, 3 Apr 2012 13:47:05 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jirislaby@...il.com" <jirislaby@...il.com>,
	Mikael Starvik <starvik@...s.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>
Subject: Re: [PATCH 02/69] TTY: crisv10, initialize tty_port

On Mon, Apr 02, 2012 at 01:53:46PM +0200, Jiri Slaby wrote:
> The tty_port used in the driver is left uninitialized. Add the
> initialization there.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Mikael Starvik <starvik@...s.com>

Looks good!

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> Cc: linux-cris-kernel@...s.com
> ---
>  drivers/tty/serial/crisv10.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
> index 004ee2e..80b6b1b 100644
> --- a/drivers/tty/serial/crisv10.c
> +++ b/drivers/tty/serial/crisv10.c
> @@ -4462,6 +4462,7 @@ static int __init rs_init(void)
>  				info->enabled = 0;
>  			}
>  		}
> +		tty_port_init(&info->port);
>  		info->uses_dma_in = 0;
>  		info->uses_dma_out = 0;
>  		info->line = i;
> -- 
> 1.7.9.2
> 
/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/