linux-kernel - Re: [PATCH] xen/gntdev: do not set VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403131947.GC12464@phenom.dumpdata.com>
Date:	Tue, 3 Apr 2012 09:19:47 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/gntdev: do not set VM_PFNMAP

On Tue, Apr 03, 2012 at 12:25:02PM +0100, Stefano Stabellini wrote:
> Since when we are using the m2p_override it is not true anymore that the
        ^^^^ - get rid of that.
> mmap'ed area doesn't have corresponsing struct pages.

That reads to me as !!do struct page. Which comes out as:

"m2p_override_* API the mmap-ed are have corresponding struct pages' ?


> 
> Removing the VM_PFNMAP flag makes get_user_pages work on the mmap'ed user vma.
> An example test case would be using a Xen userspace block backend
> (QDISK) on a file on NFS using O_DIRECT.
> 
> The patch should be backported back to 2.6.38.

Add CC: stable@...nel.org then. But does this patch depend on other
patches?

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>  drivers/xen/gntdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 99d8151..1ffd03b 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -722,7 +722,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>  	vma->vm_flags |= VM_RESERVED|VM_DONTEXPAND;
>  
>  	if (use_ptemod)
> -		vma->vm_flags |= VM_DONTCOPY|VM_PFNMAP;
> +		vma->vm_flags |= VM_DONTCOPY;
>  
>  	vma->vm_private_data = map;
>  
> -- 
> 1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/