linux-kernel - Re: [PATCH v2] toshiba_acpi: Add support for transflective LCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Apr 2012 09:07:24 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Akio Idehara <zbe64533@...il.com>
Cc:	mjg59@...f.ucam.org, platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] toshiba_acpi: Add support for transflective LCD

On Tue, Apr 03, 2012 at 10:57:28PM +0900, Akio Idehara wrote:
> Hi, Seth.
> 
> Thank you for reviewing my code again and again.
> All your comments make sense.
> I'll try to make the v3 patch.

Great!

I realized I also forgot to mention, it would be better to come up with
a more descriptive name than tmp for the local variable you added to
get_lcd() as well.

Thanks,
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/