linux-kernel - Re: [PATCH] printk(): add KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333470428.26079.39.camel@joe2Laptop>
Date:	Tue, 03 Apr 2012 09:27:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kay Sievers <kay@...y.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] printk(): add KERN_CONT where needed

On Tue, 2012-04-03 at 18:20 +0200, Kay Sievers wrote:
> On Tue, Apr 3, 2012 at 18:16, Joe Perches <joe@...ches.com> wrote:
> > Conversations happen all over the place and making
> > separate discussions isn't that valuable nor are
> > they really controllable.
> 
> Sure, but this is not a conversation in that sense, you reply to a
> patch that something is not correct, but what's not correct is not a
> subject of the patch. And that I need to correct.
> 
> > Just write the change log to simply state "add KERN_CONT"
> > without mentioning your unpublished stuff.
> 
> The changelog says:
> 
> "A prototype for kmsg records instead of a byte-stream buffer revealed
> a couple of missing printk(KERN_CONT ...) uses. Subsequent calls produce
> one record per printk() call, while all should have ended up in a single
> record."
> 
> What else do you need?

You need less.

This has nothing to do with the current printk subsystem,
it has only to do with using KERN_CONT.

Maybe:

trivial: add some KERN_CONT markers to continuation lines

or something like:

commit 66d0ae4d6ffa45b8e6d8bdbf85f8f1b285c8152d
Author: Jiri Slaby <jirislaby@...il.com>
Date:   Sun Dec 6 16:16:24 2009 +0100

    PM / Hibernate: Swap, use KERN_CONT
    
    Use KERN_CONT in save_image() for printks, so that anybody won't
    try to add a loglevel.
    
    Signed-off-by: Jiri Slaby <jirislaby@...il.com>
    Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/