linux-kernel - Re: [PATCH-v3] Support M95040 SPI EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403171736.GD2477@pengutronix.de>
Date:	Tue, 3 Apr 2012 19:17:36 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	Ivo Sieben <meltedpianoman@...il.com>,
	linux-kernel@...r.kernel.org, Jean Delvare <khali@...ux-fr.org>,
	Kevin Hilman <khilman@...prootsystems.com>
Subject: Re: [PATCH-v3] Support M95040 SPI EEPROM


> > > > +	/*
> > > > +	 * Certain EEPROMS have a size that is larger than the number of address
> > > > +	 * bytes would allow (e.g. like M95040 from ST that has 512 Byte size
> > > > +	 * but uses only one address byte (A0 to A7) for addressing.) For
> > > > +	 * the extra address bit (A8, A16 or A24) bit 3 of the instruction byte
> > > > +	 * is used. This instruction bit is normally defined as don't care for
> > > > +	 * other AT25 like chips.
> > > > +	 */
> > > > +#define EE_INSTR_BIT3_IS_ADDR	0x0010
> > > 
> > > Is there some guarantee that this chip flag will always have this
> > > meaning?
> > 
> > ? This is a driver flag.
> 
> Sorry, I don't see it set anywhere, so unclear on where it comes from.
> I thought it was from a generic spi probe.

Yeah, agreed, 'struct spi_eeprom' does not sound much like platform_data :/
Thanks for checking.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)