linux-kernel - Re: [PATCH] sky2: fix missing register reset on error path in sky2_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120403.163008.1865240185992444794.davem@davemloft.net>
Date:	Tue, 03 Apr 2012 16:30:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	LinoSanfilippo@....de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: fix missing register reset on error path in
 sky2_test_msi()

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 3 Apr 2012 11:55:47 -0700

> On Fri, 30 Mar 2012 19:36:16 +0200
> Lino Sanfilippo <LinoSanfilippo@....de> wrote:
> 
>> In sky2_test_msi() the temporarily set SW IRQ in B0 register is not reset in case
>> that request_irq() fails.
>> With this patch we only set the interrupt mask if request_irq() was successful.
>> 
>> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
> 
> Ok, but this is a non-serious error case. If request_irq() fails here,
> the driver is going to fail to load and on the failure path of
> sky2_probe will reset the chip on the way out.

So, ACK for net-next?  Toss it?  What?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/