linux-kernel - Re: [PATCH] printk(): add KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333424865.26079.9.camel@joe2Laptop>
Date:	Mon, 02 Apr 2012 20:47:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kay Sievers <kay@...y.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] printk(): add KERN_CONT where needed

On Tue, 2012-04-03 at 05:00 +0200, Kay Sievers wrote:
> On Tue, Apr 3, 2012 at 04:36, Joe Perches <joe@...ches.com> wrote:
> > A couple of other trivial comments:
> > It's better to try to coalesce multiple printks(KERN_CONT
> > (perhaps it's better to use pr_cont instead too)
> > Branches with the same printks should be hoisted where
> > possible.
> Sure, please send patches for anything that is more appropriate to use here.
> I did not want to change any logic which needs to be tested. I just
> trivially added the obviously missing prefix, which solved the
> problem, and which could be applied right away.

I think you should do it "right" rather than add
trivial markers.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/