linux-kernel - Re: [patch] cgroups: disallow attaching kthreadd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2012 14:30:49 +0200
From:	Mike Galbraith <mgalbraith@...e.de>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Tejun Heo <tj@...nel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Li Zefan <lizf@...fujitsu.com>,
	Paul Menage <paul@...lmenage.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch] cgroups: disallow attaching kthreadd

On Wed, 2012-04-04 at 04:29 -0700, David Rientjes wrote:

> I've never seen a nack from Peter on this, I only remember discussing 
> whether this needs to be isolated to only cpusets or whether it needs to 
> be a generic cgroup thing and I've always argued in favor of localizing it 
> to cpusets because that cgroup happens to care about cpu affinity where 
> others don't and this is why cgroups have ->can_attach() functions.  If a 
> cgroup were created to have nothing to do with cpu affinity (only for 
> collecting statistics for threads within it, for example), there's 
> absolutely no reason why we need to exclude kthreadd.

Well, he didn't actually say "NAK", but was against it, which means
pretty much the same thing as NAK to me.. we can call it a nak.

> You know I've been very supportive of getting this fix included for 
> cpusets in the past and I very much appreciate your time and patience in 
> the review cycle.  I'm hoping we can finally do this.

Whatever floats the boat works for me.  Peter likes generic, you like
targeted.  I like generic best too fwtw, but I don't get to make the
command decision, else you'd be saying revert, and I'd be saying NAK :)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/