linux-kernel - Re: [PATCH] mfd: Silence uninitialized variable warning for wm8994-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120405095754.GF3129@opensource.wolfsonmicro.com>
Date:	Thu, 5 Apr 2012 10:57:55 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: Silence uninitialized variable warning for
 wm8994-core

On Thu, Apr 05, 2012 at 11:49:12AM +0800, Axel Lin wrote:

> -	int ret, i, patch_regs;
> +	int ret, i, patch_regs = 0;

This just unconditionally squashes any possible warnings from this which
isn't great.  If we're going to work around flow analysis bugs like this
it's better to do it by doing something like adding an assignment in the
paths that GCC isn't figuring out than by just squashing everything.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)