linux-kernel - Re: [PATCH 4/4] compat: add some tracing backport work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1333629184.3494.12.camel@jlt3.sipsolutions.net>
Date:	Thu, 05 Apr 2012 14:33:04 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Luis R. Rodriguez" <mcgrof@...badil.infradead.org>
Cc:	"Luis R. Rodriguez" <mcgrof@...jolero.org>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	lf_driver_backport@...ts.linux-foundation.org
Subject: Re: [PATCH 4/4] compat: add some tracing backport work

On Wed, 2012-03-28 at 06:00 -0400, Luis R. Rodriguez wrote:

> I've managed to backport tracing it seems, even when CONFIG_TRACEPOINTS
> is enabled.

Nope, you've managed to completely kill tracing.


> +#undef __DECLARE_TRACE
> +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
> +	static inline void trace_##name(proto)				\
> +	{ }								\
> +	static inline void trace_##name##_rcuidle(proto)		\
> +	{ }								\
> +	static inline int						\
> +	register_trace_##name(void (*probe)(proto))			\
> +	{								\
> +		return -ENOSYS;						\
> +	}								\
> +	static inline void						\
> +	unregister_trace_##name(void (*probe)(proto))			\
> +	{								\
> +		return -ENOSYS;						\
> +	}								\
> +	static inline void check_trace_callback_type_##name(void (*cb)(data_proto)) \
> +	{								\
> +	}

All of this simply completely kills tracing. Worse, the tracepoints get
registered, but their trace_##name functions do nothing, so you can
think that they're there, but they never record data ...

The old way was much better. Can we just let 2.6.24 and the other
ancients die in peace?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/