linux-kernel - Re: [PATCH 4/6] sound/pci/hda: Remove CD control from model=benq for CX20549

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hehs2fdvs.wl%tiwai@suse.de>
Date:	Thu, 05 Apr 2012 16:32:23 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Michael Karcher <kernel@...rcher.dialup.fu-berlin.de>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] sound/pci/hda: Remove CD control from model=benq for CX20549

At Thu, 05 Apr 2012 15:30:25 +0200,
Michael Karcher wrote:
> 
> The ID used for detection of the BenQ R55E actually identifies the
> Quana TW3 ODM design, which is also used for the Gigabyte W551 laptop
> series. Schematics on the internet clearly indicate that the "Port C"
> (analog input connected to record source #4 and mixer input #4) is
> unconnected.

Well, such an action needs to be done carefully since the
documentation often lies.  But I also doubt that there is any analog
CD line.  If this is confirmed that actually it's not present on the
real machine, fine to remove it indeed.


Takashi


> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index bd7e7ce..8d7a977 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -695,7 +695,6 @@ static const struct hda_input_mux cxt5045_capture_source = {
>  static const struct hda_input_mux cxt5045_capture_source_benq = {
>  	.num_items = 5,
>  	.items = {
> -		{ "CD",     0x4 },
>  		{ "Internal Mic", 0x1 },
>  		{ "Mic", 0x2 },
>  		{ "Line In", 0x3 },
> @@ -820,9 +819,6 @@ static const struct snd_kcontrol_new cxt5045_mixers[] = {
>  };
>  
>  static const struct snd_kcontrol_new cxt5045_benq_mixers[] = {
> -	HDA_CODEC_VOLUME("CD Playback Volume", 0x17, 0x4, HDA_INPUT),
> -	HDA_CODEC_MUTE("CD Playback Switch", 0x17, 0x4, HDA_INPUT),
> -
>  	HDA_CODEC_VOLUME("Line In Playback Volume", 0x17, 0x3, HDA_INPUT),
>  	HDA_CODEC_MUTE("Line In Playback Switch", 0x17, 0x3, HDA_INPUT),
>  
> -- 
> 1.7.9.1
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/