linux-kernel - Re: [PATCH v3] toshiba_acpi: Add support for transflective LCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F7DAE00.6010101@gmail.com>
Date:	Thu, 05 Apr 2012 23:36:48 +0900
From:	Akio Idehara <zbe64533@...il.com>
To:	seth.forshee@...onical.com
CC:	mjg59@...f.ucam.org, platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] toshiba_acpi: Add support for transflective LCD

Seth Forshee wrote:

> I'm still not crazy about the name. And really I think if
> get_tr_backlight_status() is going to return an error code, when it
> fails the return value should be propogated (even if it's the same in
> this case). How about this?


Thank you for your suggestion.  I agree with you.  I'll try to make a
new patch again.

>>  static const struct backlight_ops toshiba_backlight_data = {
>> +	.options	= BL_CORE_SUSPENDRESUME,
> 
> What's the reason for adding this? I don't see that it's useful unless
> we're handling BL_CORE_SUSPENDED, which toshiba_acpi is not doing.


The reason is to restore transflective status, which is always disabled
after resuming.  If BL_CORE_SUSPENDRESUME is added,
set_lcd_state_status() is called from backlight_update_status() with
stored brightness. So, when its brightness is 0, transflective status is
enabled after resuming.


Best Regards,
Akio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/