linux-kernel - Re: BUG at cpuidle_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F7E0A6A.40204@amd.com>
Date:	Thu, 5 Apr 2012 17:11:06 -0400
From:	Boris Ostrovsky <boris.ostrovsky@....com>
To:	Jiri Slaby <jslaby@...e.cz>, Len Brown <len.brown@...el.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	the arch/x86 maintainers <x86@...nel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Toshi Kani <toshi.kani@...com>
Subject: Re: BUG at cpuidle_play_dead

On 04/05/12 17:03, Jiri Slaby wrote:
> Hi,
>
> I'm hitting this BUG as the last thing during shutdown:
> BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8
> IP: [<ffffffff814ab60d>] cpuidle_play_dead+0x1d/0xb0
>
>
> It's because drv is NULL. The problem is gone if I do this:
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -83,6 +83,11 @@ int cpuidle_play_dead(void)
>          int i, dead_state = -1;
>          int power_usage = -1;
>
> +       if (!drv) {
> +               printk("DRIVER IS NULL\n");
> +               return -ENODEV;
> +       }
> +
>          /* Find lowest-power state that supports long-term idle */
>          for (i = CPUIDLE_DRIVER_STATE_START; i<  drv->state_count; i++) {
>                  struct cpuidle_state *s =&drv->states[i];
>
> thanks,


This was already fixed in https://lkml.org/lkml/2012/3/31/249.

Len, please apply that patch.

Thanks.
-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/