linux-kernel - Re: [PATCH] LEDS: LED module for DA9052/53 PMIC v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120405155258.6af697f3.akpm@linux-foundation.org>
Date:	Thu, 5 Apr 2012 15:52:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>, <rpurdie@...ys.net>,
	<linux-kernel@...r.kernel.org>,
	David Dajun Chen <Dajun.Chen@...semi.com>
Subject: Re: [PATCH] LEDS: LED module for DA9052/53 PMIC v2

On Wed, 22 Feb 2012 18:39:09 +0530
Ashish Jangam <ashish.jangam@...tcummins.com> wrote:

> LED Driver for Dialog Semiconductor DA9052/53 PMICs.
> 
> Signed-off-by: David Dajun Chen <dchen@...semi.com>

This email was cc'ed to Dajun.Chen@...semi.com.  I'll assume that both
work correctly.

>  drivers/leds/Kconfig       |    8 ++
>  drivers/leds/Makefile      |    1 +
>  drivers/leds/leds-da9052.c |  214 ++++++++++++++++++++++++++++++++++++++++++++

Looks OK.  I added one little fixup:

--- a/drivers/leds/leds-da9052.c~leds-led-module-for-da9052-53-pmic-v2-fix
+++ a/drivers/leds/leds-da9052.c
@@ -40,7 +40,7 @@ struct da9052_led {
 	int brightness;
 };
 
-unsigned char led_reg[] = {
+static unsigned char led_reg[] = {
 	DA9052_LED_CONT_4_REG,
 	DA9052_LED_CONT_5_REG,
 };

This array could actually be made static within da9052_set_led_brightness().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/