lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4F7EA0E8.1070809@hitachi.com>
Date:	Fri, 06 Apr 2012 16:53:12 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Sasikantha babu <sasikanth.v19@...il.com>
Cc:	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, yrl.pp-manager.tt@...achi.com
Subject: Re: [PATCH] Kprobes : Recursively remove the directory on failure

(2012/04/04 0:35), Sasikantha babu wrote:
> Remove the "kprobes" directory recursivly if "enabled" file creation fails
> 
> Signed-off-by: Sasikantha babu <sasikanth.v19@...il.com>

Right,  this should remove recursively, because there is
"list" file already.
Thank you!

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

> ---
>  kernel/kprobes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index c62b854..9b45515 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2251,7 +2251,7 @@ static int __kprobes debugfs_kprobe_init(void)
>  	file = debugfs_create_file("enabled", 0600, dir,
>  					&value, &fops_kp);
>  	if (!file) {
> -		debugfs_remove(dir);
> +		debugfs_remove_recursive(dir);
>  		return -ENOMEM;
>  	}
>  


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ