linux-kernel - Re: [PATCH] samsung-laptop: unregister ACPI video module for some well known laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Apr 2012 11:42:18 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux acpi <linux-acpi@...r.kernel.org>,
	Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] samsung-laptop: unregister ACPI video module for some
 well known laptops

On Tue, Mar 27, 2012 at 1:21 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> On Tue, Mar 27, 2012 at 11:11:18AM +0200, Corentin Chary wrote:
>> Matthew, is this one ok ? I really hope this patch can go in 3.4 so we
>> don't introduce a regression for old laptops.
>
> Yes, I've got this now.
>
> Thanks,

A user just found a DSDT which is broken by this way of doing things
(this is not really a regression since it was also broken before).

_BCL contains a wierd "Or (VDRV, 0x02, VDRV)".
So if you call _BLC once (video.ko will), it set a flag that affect
the behavior of all backlight related stuff, and it breaks
samsung-laptop's backlight even if samsung-laptop unload the acpi
backlight.
Using acpi_backlight=vendor solves that since it prevents the module
from being loaded. My previous patch also fix that since it use
acpi_backlight= mechanism.

Do you think using acpi_backlight=vendor is a good enought solution
here ? Should we use my first patch instead ?

-- 
Corentin Chary
http://xf.iksaif.net

Download attachment "acpidump.bin.gz" of type "application/x-gzip" (45898 bytes)