linux-kernel - Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1204061312210.2542@ionos>
Date:	Fri, 6 Apr 2012 13:12:52 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andreas Schwab <schwab@...ux-m68k.org>
cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	devicetree-discuss@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Milton Miller <miltonm@....com>,
	Rob Herring <rob.herring@...xeda.com>
Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use
 irq_alloc_desc() instead

On Thu, 5 Apr 2012, Andreas Schwab wrote:
> Grant Likely <grant.likely@...retlab.ca> writes:
> 
> > I bet it is NR_IRQS related.  You have SPARSE_IRQ enabled, which means
> > the maximum number of irq_descs is IRQ_BITMAP_BITS (NR_IRQS + 8192).
> 
> The actual definition uses NR_IRQS + 8196.  Guess that's a typo.  (Does
> it really make sense to add NR_IRQS here?)
> 
> > diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h
> > index cf417e51..9edf499 100644
> > --- a/arch/powerpc/include/asm/irq.h
> > +++ b/arch/powerpc/include/asm/irq.h
> > @@ -20,7 +20,7 @@
> >  
> >  /* Define a way to iterate across irqs. */
> >  #define for_each_irq(i) \
> > -       for ((i) = 0; (i) < NR_IRQS; ++(i))
> > +       for ((i) = 0; (i) < nr_irqs; ++(i))
> 
> There are exactly two uses of for_each_irq, one is related to cpu
> hotplug, the other to kexec, so that cannot make any difference.

Though that wants to be fixed nevertheless.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/