linux-kernel - Re: [PATCH 04/15] events: Update tools/lib/traceevent to work with perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120406114812.GE30425@liondog.tnic>
Date:	Fri, 6 Apr 2012 13:48:12 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <srostedt@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>, Arun Sharma <asharma@...com>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 04/15] events: Update tools/lib/traceevent to work with
 perf

On Fri, Apr 06, 2012 at 12:47:55AM +0200, Frederic Weisbecker wrote:
> From: Steven Rostedt <srostedt@...hat.com>
> 
> Some of the util functions of libtraceevent.a conflict with perf,
> such as die(), warning() and others. Move them into event-util.h

Minor: judging by the patch below, you mean "event-utils.h" here.

> that is not included by the perf tools.
> 
> Also, as perf compiles with 'bool' the filter_arg->bool needs to
> be renamed to filter_arg->boolean.
> 
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Arnaldo Carvalho de Melo <acme@...radead.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Arun Sharma <asharma@...com>
> Cc: Namhyung Kim <namhyung.kim@....com>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  tools/lib/traceevent/event-parse.c  |    1 +
>  tools/lib/traceevent/event-parse.h  |   20 +++-----------------
>  tools/lib/traceevent/event-utils.h  |   16 ++++++++++++++++
>  tools/lib/traceevent/parse-filter.c |   32 ++++++++++++++++----------------
>  tools/lib/traceevent/trace-seq.c    |    1 +
>  5 files changed, 37 insertions(+), 33 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 47a3227..3ce75b5 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -33,6 +33,7 @@
>  #include <errno.h>
>  
>  #include "event-parse.h"
> +#include "event-utils.h"

	     ^^^^^^^^^^^^^

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/