linux-kernel - Re: [PATCH 25/40] parisc: Use set_current_blocked() and block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120406145915.GC15318@bombadil.infradead.org>
Date:	Fri, 6 Apr 2012 10:59:15 -0400
From:	Kyle McMartin <kyle@...artin.ca>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	linux-arch@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Matt Fleming <matt.fleming@...el.com>,
	Helge Deller <deller@....de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH 25/40] parisc: Use set_current_blocked() and
 block_sigmask()

On Tue, Feb 14, 2012 at 11:40:58AM +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@...el.com>
> 
> As described in e6fa16ab ("signal: sigprocmask() should do
> retarget_shared_pending()") the modification of current->blocked is
> incorrect as we need to check whether the signal we're about to block
> is pending in the shared queue.
> 
> Also, use the new helper function introduced in commit 5e6292c0f28f
> ("signal: add block_sigmask() for adding sigmask to current->blocked")
> which centralises the code for updating current->blocked after
> successfully delivering a signal and reduces the amount of duplicate
> code across architectures. In the past some architectures got this
> code wrong, so using this helper function should stop that from
> happening again.
> 
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Kyle McMartin <kyle@...artin.ca>
> Cc: Helge Deller <deller@....de>
> Cc: "James E.J. Bottomley" <jejb@...isc-linux.org>
> Cc: linux-parisc@...r.kernel.org
> Signed-off-by: Matt Fleming <matt.fleming@...el.com>

Nice cleanups Matt!

Acked-by: Kyle McMartin <kyle@...artin.ca>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/