linux-kernel - Re: [PATCH -v3 40/47] PCI: Add pci bus removal through /sys/.../pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6gitMTVXeMBOSJFRHvQT_iJ-RGmLduYsGEM+3YAPE2CQ@mail.gmail.com>
Date:	Fri, 6 Apr 2012 10:07:03 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Jiang Liu <liuj97@...il.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>, x86 <x86@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH -v3 40/47] PCI: Add pci bus removal through /sys/.../pci_bus/.../remove

On Fri, Apr 6, 2012 at 10:01 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> On Fri, Apr 6, 2012 at 8:50 AM, Jiang Liu <liuj97@...il.com> wrote:
>> Hi Yinghai,
>>        I found many other drivers assume that a pci bus won't disappear if
>> the corresponding PCI bridge device still exists. The sysfs interface proposed
>> here breaks that assumption and may cause many access-after-free issues.
>> So what's the purpose of this interface? Should we remove this interface or
>> enhance other drivers to avoid invalid memory access issues?

Can you point out some of the specifics about drivers making this
assumption?  I'm not thrilled about the idea of removing a pci_bus
while the upstream bridge pci_dev still exists either.

> ok, will make it only show up on root bus.

OK.  I'm still interested in the specifics because I don't like the
way the pci_bus is exposed, even inside the kernel.  The bus itself is
not an active entity, and we can't really do anything with it except
by touching a device connected to it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/