linux-kernel - [PATCH]block: make auto block plug flush threshold per-disk based

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Apr 2012 11:27:01 -0600
From:	Shaohua Li <shli@...nel.org>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"axboe@...nel.dk" <axboe@...nel.dk>
Subject: [PATCH]block: make auto block plug flush threshold per-disk based

Subject: block: make auto block plug flush threshold per-disk based

We do auto block plug flush to reduce latency, the threshold is 16
requests. This works well if the task is accessing one or two drives.
The problem is if the task is accessing a raid 0 device and the raid
disk number is big, say 8 or 16, 16/8 = 2 or 16/16=1, we will have
heavy lock contention.

This patch makes the threshold per-disk based. The latency should be
still ok accessing one or two drives. The setup with application
accessing a lot of drives in the meantime uaually is big machine,
avoiding lock contention is more important, because any contention
will actually increase latency.

Signed-off-by: Shaohua Li <shli@...ionio.com>
---
  block/blk-core.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux/block/blk-core.c
===================================================================
--- linux.orig/block/blk-core.c	2012-04-06 10:51:29.766932123 -0600
+++ linux/block/blk-core.c	2012-04-06 10:56:46.386929357 -0600
@@ -1277,7 +1277,8 @@
  	list_for_each_entry_reverse(rq, &plug->list, queuelist) {
  		int el_ret;

-		(*request_count)++;
+		if (rq->q == q)
+			(*request_count)++;

  		if (rq->q != q || !blk_rq_merge_ok(rq, bio))
  			continue;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/