linux-kernel - Re: [PATCH] net/core: Fix seeking in /proc/net/dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333734079.3007.4.camel@edumazet-glaptop>
Date:	Fri, 06 Apr 2012 19:41:19 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Mihai Maruseac <mmaruseac@...acom.com>
Cc:	John Keeping <john@...ping.me.uk>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mihai Maruseac <mihai.maruseac@...il.com>,
	Daniel Baluta <dbaluta@...acom.com>
Subject: Re: [PATCH] net/core: Fix seeking in /proc/net/dev

On Fri, 2012-04-06 at 20:14 +0300, Mihai Maruseac wrote:
> On Fri, Apr 6, 2012 at 8:05 PM, John Keeping <john@...ping.me.uk> wrote:
> > Commit f04565ddf52e4 (dev: use name hash for dev_seq_ops) introduced
> > code that fails to check the requested position when getting an item for
> > /proc/net/dev.  This means that any code which seeks within this file is
> > likely to receive corrupted data.
> >
> > A test case for this is to use the read builtin in bash:
> >
...
> Looks good to me. However, Eric just submitted a patch here with other
> changes caused by a logic error in the original patch.

Hmm, I think my patch fixed this lseek issue as well.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/