linux-kernel - Re: [PATCH 0/6] rework quirks for the "kt" serial port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABE8wwuLjqF1um8eJMap+6f_L3_upJL1VkQrxRfHXn-6R1Kuwg@mail.gmail.com>
Date:	Fri, 6 Apr 2012 12:49:39 -0700
From:	"Williams, Dan J" <dan.j.williams@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	alan@...ux.intel.com
Subject: Re: [PATCH 0/6] rework quirks for the "kt" serial port

On Fri, Apr 6, 2012 at 12:14 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Fri, Apr 06, 2012 at 11:44:22AM -0700, Dan Williams wrote:
>> The kt serial port intermittently reports unreliable data in its IIR
>> register and needs to reset fifos to stay in sync with firmware when the
>> device is reset.
>>
>> The IIR fixes that went into 3.3 were not complete so patch 3 replaces
>> them with an explicit way to turn on UART_BUG_THRE (i.e. the "I don't
>> trust my iir" flag).
>>
>
> So the first 3 patches should go into 3.4 (and 3.3-stable) kernels,
> right?

Yes, since this fixes the workaround that went into 3.3 properly and
addresses a regression.

>> A new fix for resetting the fifos on device reset is patch 5.  Alan
>> asked to make this a new quirk rather than add more workarounds to the
>> core (patch 4).
>
> These can wait for 3.5?

I think they can wait especially because of the cross tree changes.

>> Patch 6 is an untested RFC / RFT from anyone that has a serial
>> suspend/resume use case with an 'init' quirk that has resources that
>> need de-allocation at 'exit'.
>
> And I'll hold off on this one entirely for now, right?

Yeah, if anyone runs into a similar problem with serial suspend /
resume they may want to take a look at this patch.  But for now I
don't have a valid test case for it.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/