linux-kernel - Re: [PATCH] printk: support structured and multi-facility log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333674768.23520.123.camel@joe2Laptop>
Date:	Thu, 05 Apr 2012 18:12:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kay Sievers <kay@...y.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartmann <greg@...ah.com>
Subject: Re: [PATCH] printk: support structured and multi-facility log
 messages

On Thu, 2012-04-05 at 21:47 +0200, Kay Sievers wrote:

> Better?
> 
>   [root@mop ~]# cat /dev/kmsg
[]
>   6,5,0; BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
>   6,6,0; BIOS-e820: 0000000000100000 - 000000001fffd000 (usable)
>   6 ,7,0; BIOS-e820: 000000001fffd000 - 0000000020000000 (reserved)

Not really, why the space between the 6 and the comma?

> This patch extends printk() to be able to attach arbitrary key/value
> pairs to logged messages,

Bad commit changelog.

It does not extend printk().  printk() is a function call.

It extends the message logging subsystem to include the
printk_emit() and vprintk_emit() functions, which can
add decidedly not arbitrary key/value pairs, but some
additional subsystem specific information.

> - Output of dev_printk() is reliably machine-readable now.

No, it's not.

An output header simply contains additional
structured information.  The message portion
can still be arbitrary gobbledygook.

I still think this should be 3 patches not 1.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/