linux-kernel - Re: [GIT pull] timer updates for 3.4-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120406165824.c2ae2719.akpm@linux-foundation.org>
Date:	Fri, 6 Apr 2012 16:58:24 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	David Rientjes <rientjes@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT pull] timer updates for 3.4-rc

On Sat, 7 Apr 2012 01:48:51 +0200 (CEST)
Thomas Gleixner <tglx@...utronix.de> wrote:

> On Fri, 6 Apr 2012, David Rientjes wrote:
> 
> > On Sat, 7 Apr 2012, Thomas Gleixner wrote:
> > 
> > > diff --git a/kernel/itimer.c b/kernel/itimer.c
> > > index 22000c3..c70369a 100644
> > > --- a/kernel/itimer.c
> > > +++ b/kernel/itimer.c
> > > @@ -284,8 +284,11 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
> > >  	if (value) {
> > >  		if(copy_from_user(&set_buffer, value, sizeof(set_buffer)))
> > >  			return -EFAULT;
> > > -	} else
> > > +	} else {
> > >  		memset((char *) &set_buffer, 0, sizeof(set_buffer));
> > > +		WARN_ONCE(1, "setitimer: new_value pointer is NULL."
> > > +			  " Misfeature support will be removed\n");
> > > +	}
> > >  
> > >  	error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL);
> > >  	if (error || !ovalue)
> > 
> > When I tried doing this for the deprecated /proc/pid/oom_adj there was a 
> > complaint that WARN_ONCE() screws up log parsing scripts that think there 
> > is a kernel issue so I had to change it to printk_once() and include 
> > get_task_comm(current) and current->pid.  See
> > http://lkml.indiana.edu/hypermail/linux/kernel/1108.0/00446.html
> 
> Bah.

It gives you a chance to remove the unneeded cast from the memset call ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/